I noticed this in the notes: "Initial concept ACK. Perhaps someone else here can give some use-cases? pg156: it looks like there's not much motivation for this change given in the PR or associated issue. I will say Concept ACK but experience with codebase none existent concept ACK, currently theres a test failure. Approach ACK, waiting for a bug to be fixed before tACK I read the notes and questions and the PR, but I don't have enough information to give a concept ACK, because I don't understand how the fee data will exactly help the user. Did you review the PR? Concept ACK, approach ACK, tested ACK, or NACK? Who had a chance to review the PR and notes/questions this week? (y/n) I’ll use those questions to guide the conversation, but feel free to jump in at any point if you have questions or comments. Notes and questions are in the normal place: maxe: you're very welcome! Feel free to ask questions at any point if anything is unclear. Feel free to say hi to let people know you're here TxToJSON() now always calls TxToUniv() with verbosity set to TxVerbosity::SHOW_DETAILS_AND_PREVOUT,Įven if the RPC user called the function with verbosity set to 1. They used for? How/where do they get set?Īre there any performance implications of that loop? Do they matter? Local variables blockUndo and block in the getrawtransaction() function. Happens if 3 is passed as the argument? How about -1? Transaction, including fees and prevout information for the inputs). The transaction) or 2 (returns an object with information about the The verbosity argument accepts values of 0 (returns the hex-encodedĭata for the transaction), 1 (returns an object with information about Is this ok? Does it break backwards compatibility? Of getrawtransaction from verbose (a bool) to verbosity (an int). We covered that PRĭid you review the PR? Concept ACK, approach ACK, tested ACK, or NACK? This PR updates the getrawtransaction RPC method to allow the user toĪdded fee data to the getblock RPC method. Transaction which has been saved in a block file on disk. The transaction canĮither be an unconfirmed transaction in the mempool or a confirmed RPC method can be used to retrieve a transaction. In otherįor transactions in the mempool, the UTXOs spent by the transaction willĮither be in the UTXO set (the set of all UTXOs implied by the block chainĪt the current height), or will be the outputs from other transactions inįor transactions that are already spent in the block chain, the UTXO data Transaction outputs) that are being spent in this transaction. Only way to determine the transaction fee is to look up the UTXOs (unspent Since the transaction inputs do not explicitly include the amounts, the The total amount spent by the transaction outputs. The transaction fee is the total amount from the transaction inputs minus Which each contain an amount and a spending condition (encoded as a Which each refer to an output that is being spent by txid and index, and The PR branch HEAD was f30f007c8 at the time of this review club meeting. Return fee and prevout (utxos) to getrawtransaction ( rpc/rest/zmq) Nov 17, 2021
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |